Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin index tool version as the bug in the new release #1128

Merged
merged 1 commit into from Sep 7, 2023
Merged

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Sep 7, 2023

Proposed changes

Pin the index tool to a lower version as it has an issue related to opendatacube/datacube-core#1490. Also #1113 not caused by the index tool by the dependency of pystac. So the sandbox docker image will pin jsonschema<4.18 for compatibility.

Closes issues (optional)

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Copy link
Collaborator

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emma, appreciated!

@robbibt robbibt merged commit b9d7542 into develop Sep 7, 2023
2 checks passed
@robbibt robbibt deleted the update_test branch September 7, 2023 22:35
robbibt added a commit that referenced this pull request Sep 8, 2023
pin index tool version as the bug in the new release (#1128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants