NPI-3060 Remove duplicated epochs in SP3 reader (with warning) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldmaj
previously approved these changes
Jan 15, 2024
| # Check for duplicate epochs, dedupe and log warning | ||
| duplicated_indexes = sp3_df.index.duplicated() | ||
| if duplicated_indexes.sum() > 0: # We have dupes | ||
| first_dupe = sp3_df.index.get_level_values(0)[duplicated_indexes][0] |
There was a problem hiding this comment.
Not sure if it is worth it to list out all indexes or rows that are copied out (to show the scale of the problem?)
Perhaps doing something like sp3_df.index.get_level_values(0)[duplicated_indexes].sum() / 2 should reveal the number of entries that are copied? Not entirely sure on this so it would need to be tested
There was a problem hiding this comment.
Updated to output the count in the warning. By the doc, it's by default the number of entries which duplicate something already there. So a (possibly repeated) list of duplicated values. I've worded the warning to try and capture that.
…larifying comment
ronaldmaj
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated epochs should not be present in SP3 files. A warning is now logged if any are found. Detecting and removing duplicates also allows comparisons to be run on less compliant data.
The actual duplicate check is done on the Pandas DataFrame with
Index.duplicated(). A quick test suggests this executes in less than 1ms on a typical SP3 file, so is not a performance concern.