Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sp3 dupe check \w has_duplicates property #8

Merged
merged 1 commit into from Jan 15, 2024

Conversation

bmatv
Copy link
Collaborator

@bmatv bmatv commented Jan 15, 2024

As has_duplicates is an already a property inside the sp3 dataframe it is literally free. You may argue that index.duplicated() before if is not a waste as you still need it to compute first dupe, but I could speculate that 99% of sp3 files come without dupes.

Copy link
Collaborator

@treefern treefern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement :) This is also a bit more readable.

@ronaldmaj ronaldmaj merged commit d3e5b52 into GeoscienceAustralia:main Jan 15, 2024
@bmatv
Copy link
Collaborator Author

bmatv commented Jan 15, 2024

@treefern Originally I added a comment on has_duplicates to you branch but never clicked on Finish your review button so it was a pending [read as invisible] comment. But this branch is also a great test on how-to commit/merge etc when one is a poor contributor, not a maintainer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants