New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UnicodeDecodeError in setup.py. #171
Conversation
Although I couldn't reproduce the problem, I agree that explicit decoding is definitively the right thing to do here. Personally, I'd avoid the Python 3 if/else, though and just explicitly
|
Using |
I agree, Python versions (2.7 and 3.x) should be specified in setup.py. |
https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge, I'd say @karimbahgat
Looks good, thanks for the swift fix! |
As mentioned in #169,
setup.py
fails to read theREADME.md
due to anUnicodeDecodeError
.This is fixed by explicitly setting the encoding, and using the
codecs
library with Python 2.7.