Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings and refactor code #2

Merged
merged 3 commits into from Feb 25, 2019
Merged

Add docstrings and refactor code #2

merged 3 commits into from Feb 25, 2019

Conversation

qpenko
Copy link
Contributor

@qpenko qpenko commented Feb 25, 2019

This is an attempt to:

  • Add docstrings to every function. Existing code comments and online resources were used to obtain function and parameters description
  • Refactor code to comply with PEP8 where possible
  • Update code for some routines to make it consistent across the package
  • Fix bugs, remove unused variables and duplicated functions

Areas that need additional attention were marked with "TODO" comment:

  • Docstring parameters without description
  • Unused variables
  • Unknown function

@GeostatsGuy GeostatsGuy merged commit bbd4ada into GeostatsGuy:master Feb 25, 2019
@GeostatsGuy
Copy link
Owner

Appreciation to Anton Kupenko for this great assistance on the package. Looking forward to working together on this package. I will add missing parameter descriptions in the next week. I'm almost done with sequential Gaussian simulation. Michael

@qpenko qpenko deleted the refactor branch February 25, 2019 21:06
jessepisel added a commit to sonyapieklik/GeostatsPy that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants