Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve map popup component #1002

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Improve map popup component #1002

merged 6 commits into from
Dec 6, 2023

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Nov 23, 2023

Improves Map Popup component to :

  • Display explicit content by adding optional content property (useful for future HD viewpoint feature)
  • Define an <a> tag for link and a <button> tag for action (useful for future HD viewpoint feature)
  • Use tailwind instead of styled component

@dtrucs dtrucs requested a review from a team November 23, 2023 12:03
dtrucs and others added 3 commits December 1, 2023 17:38
@dtrucs @Bo-Duke
Symplify getRoute helper
d5a57ad 
Co-authored-by: Maxime Bouveron <maxime.bouveron@gmail.com>
@dtrucs @Bo-Duke
Fix uncessary optional chaining
accc3b4 
Co-authored-by: Maxime Bouveron <maxime.bouveron@gmail.com>
@dtrucs
Fix the call of popupResult in map Popup component
d47abc7
@dtrucs dtrucs requested review from mabhub and Bo-Duke December 1, 2023 16:45
@dtrucs dtrucs merged commit 7b73b98 into develop Dec 6, 2023
1 check passed
@dtrucs dtrucs deleted the Improve-map-popup-component branch December 14, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo-Duke Bo-Duke Bo-Duke approved these changes

@mabhub mabhub Awaiting requested review from mabhub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtrucs @mabhub @Bo-Duke