Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize activitybar #1009

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Customize activitybar #1009

merged 10 commits into from
Jan 8, 2024

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Dec 15, 2023

@babastienne
Copy link
Member

Is it possible to improve the documentation ? I have the feeling that the documentation is minimalist in camparison with this comment that is way more detailed. At least add a link in the documentation to referecne the comment in order to not "loose" this knowledge.

What do you think @bruhnild ?

@bruhnild
Copy link
Contributor

Is it possible to improve the documentation ? I have the feeling that the documentation is minimalist in camparison with this comment that is way more detailed. At least add a link in the documentation to referecne the comment in order to not "loose" this knowledge.

What do you think @bruhnild ?

I agree, this comment is very clear and detailed and deserves to be included in the documentation to explain how the new variables in the home.json file work

Copy link
Member

@babastienne babastienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve documentation (see comments above)

@dtrucs
Copy link
Collaborator Author

dtrucs commented Dec 28, 2023

Improve documentation (see comments above)

Added 👍

@dtrucs dtrucs requested a review from a team December 28, 2023 17:07
@babastienne babastienne self-requested a review January 8, 2024 13:23
@dtrucs dtrucs changed the base branch from main to develop January 8, 2024 15:07
@dtrucs dtrucs merged commit bc53e54 into develop Jan 8, 2024
1 check passed
@dtrucs dtrucs deleted the Customize-activitybar branch January 15, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants