New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made the populateDemoData script silltle bit more user friendly #591

Merged

sebastianovide merged 1 commit into Geovation:master from sebastianovide:demo_data

Jul 8, 2020

Contributor

sebastianovide commented Jul 8, 2020

No description provided.


          made the populateDemoData script silltle bit more user friendly

5ccbece

This was linked to issues Jul 8, 2020

The demo data created by [populateDemoData.js](https://github.com/Geovation/photos/blob/179ec9c47840212d39698023c28c3c8c24213776/scripts/populateDemoData.js#L54) seems to be uploaded to a hardcoded storage bucket location #587

Closed

p.s. also, I am a little confused as to why the storageBucket seems to be a Google App Engine #588

Closed

sebastianovide merged commit a897473 into Geovation:master

coveralls commented Jul 8, 2020

Pull Request Test Coverage Report for Build 1556

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 18.678%

Totals
Change from base Build 1553:	0.0%
Covered Lines:	282
Relevant Lines:	1447

💛 - Coveralls

sebastianovide deleted the demo_data branch

July 9, 2020 09:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment