Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cordova #630

Merged
merged 6 commits into from
May 26, 2021
Merged

Remove cordova #630

merged 6 commits into from
May 26, 2021

Conversation

sebastianovide
Copy link
Contributor

@sebastianovide sebastianovide commented May 21, 2021 •
edited
Loading

fixes #632

@coveralls
Copy link

coveralls commented May 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1816

  • 9 of 39 (23.08%) changed or added relevant lines in 14 files are covered.
  • 176 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-12.5%) to 5.325%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/gtag.js 0 2 0.0%
src/App.js 0 3 0.0%
src/index.js 0 3 0.0%
src/reportWebVitals.js 0 8 0.0%
src/components/PhotoPage/index.js 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/PhotoPage/index.js 1 1.86%
src/gtag.js 1 26.67%
src/components/common/NavDots/components/NavDots.js 5 18.18%
src/components/Login.js 5 0%
src/components/PageWrapper.js 6 7.69%
src/features/firebase/authFirebase.js 6 10.71%
src/types/MapLocation.js 6 0%
src/utils/index.js 7 19.05%
src/components/common/SwipeTutorialPage.js 8 11.54%
src/components/DrawerContainer.js 8 23.08%
Totals Coverage Status
Change from base Build 1665: -12.5%
Covered Lines: 106
Relevant Lines: 1544
💛 - Coveralls

@sebastianovide sebastianovide mentioned this pull request May 25, 2021
Closed
@sebastianovide sebastianovide force-pushed the remove_cordova branch 2 times, most recently from f3ebc1b to 37ea9bb Compare May 26, 2021 15:21
joykuotw
joykuotw suggested changes May 26, 2021
View reviewed changes
.gitignore Show resolved Hide resolved
@joykuotw joykuotw merged commit 4f95eb3 into Geovation:master May 26, 2021
@sebastianovide sebastianovide deleted the remove_cordova branch June 23, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joykuotw joykuotw joykuotw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove cordova
3 participants
@sebastianovide @coveralls @joykuotw