Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing images #652

Merged
merged 8 commits into from Jun 14, 2021
Merged

Fix missing images #652

merged 8 commits into from Jun 14, 2021

Conversation

sebastianovide
Copy link
Contributor

@sebastianovide sebastianovide commented Jun 11, 2021 •
edited

fixes #642

  • stress test it
  • check adding photos
  • check real time
  • check leaderboard
  • check fresh
  • check mobile

@coveralls
Copy link

coveralls commented Jun 11, 2021 •
edited

Pull Request Test Coverage Report for Build 1868

  • 0 of 43 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 1.416%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/firebase/dbFirebase.js 0 3 0.0%
src/App.js 0 40 0.0%
Files with Coverage Reduction New Missed Lines %
src/features/firebase/dbFirebase.js 1 0%
src/App.js 5 0%
Totals Coverage Status
Change from base Build 1851: -0.004%
Covered Lines: 27
Relevant Lines: 1532
💛 - Coveralls

@sebastianovide sebastianovide force-pushed the fix_missingimages branch 2 times, most recently from a0d5a42 to f0efd31 Compare June 11, 2021 15:46
@joykuotw joykuotw merged commit 8742a1c into Geovation:master Jun 14, 2021
@sebastianovide sebastianovide deleted the fix_missingimages branch June 23, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joykuotw joykuotw joykuotw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

photos not displayed the first time
3 participants
@sebastianovide @coveralls @joykuotw