Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Feature to include 2-way in comparision #50

Merged
merged 9 commits into from
Nov 26, 2018

Conversation

YousafAzabi
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 12, 2018

Pull Request Test Coverage Report for Build 80

  • 52 of 52 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 73: 0.0%
Covered Lines: 242
Relevant Lines: 242

💛 - Coveralls

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5016 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5137 lines exceeds the maximum allowed for the inline comments feature.

@YousafAzabi
Copy link
Contributor Author

YousafAzabi commented Nov 21, 2018

This will fix #32, #33 and #53.
It works with small size maps like London, but not with whole UK (which will be done in #54)

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5149 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Nov 23, 2018

Code Climate has analyzed commit 81e36f4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sebastianovide sebastianovide merged commit 87abcb2 into Geovation:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants