Supported pinocchio with cppadcg installation #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
for more information, see https://pre-commit.ci
|
This should be fixed in pinocchio packaging, not here, and in each package dependent on pinocchio |
Agreed! I created an issue and compromise to handle it when is possible. Is this enough for now? Or would you prefer to revert this PR? |
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Dec 1, 2023
## [4.0.9] - 2023-11-29
### What's Changed
* Supported pinocchio with cppadcg installation by cmastalli in Gepetto/example-robot-data#180
* [pre-commit.ci] pre-commit autoupdate by pre-commit-ci in Gepetto/example-robot-data#181
* Verbose by nim65s in Gepetto/example-robot-data#183
* [pre-commit.ci] pre-commit autoupdate by pre-commit-ci in Gepetto/example-robot-data#184
* [pre-commit.ci] pre-commit autoupdate by pre-commit-ci in Gepetto/example-robot-data#187
* [pre-commit.ci] pre-commit autoupdate by pre-commit-ci in Gepetto/example-robot-data#188
* CMake: require >= 3.10 by nim65s in Gepetto/example-robot-data#185
* Update jrlcmakemodules to support Python 3.12 by jorisv in Gepetto/example-robot-data#190
* [pre-commit.ci] pre-commit autoupdate by pre-commit-ci in Gepetto/example-robot-data#189
* [pre-commit.ci] pre-commit autoupdate by pre-commit-ci in Gepetto/example-robot-data#191
* Sync submodule cmake by jcarpent in Gepetto/example-robot-data#192
### New Contributors
* jorisv made their first contribution in Gepetto/example-robot-data#190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to install example-robot-data when Pinocchio has been installed with CppADCogen