Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gepetto-viewer-server, fix #74 #83

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

nim65s
Copy link
Member

@nim65s nim65s commented Oct 18, 2018

No description provided.

@jcarpent
Copy link
Member

If you remove it, remove it deeply. Which means the cpp files that we do want to support anymore.

@jcarpent jcarpent self-requested a review October 18, 2018 10:17
@jcarpent
Copy link
Member

fix both #74 and #83

@jmirabel
Copy link
Contributor

The changes are not as simple as removing a cpp file.

The most interesting is that gepetto::gui::WindowsManager and graphics::WindowsManager can be merged. But this can be kept as such for now.

@nim65s
Copy link
Member Author

nim65s commented Oct 18, 2018

I'll merge this one, make a release (as @jmirabel requested it), and open a new issue about merging the classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants