Skip to content

Commit

Permalink
src/CMakeLists.txt: Need to set RP_LIBROMDATA_IS_DLL in the current *…
Browse files Browse the repository at this point in the history
…and* parent scope.

Otherwise, it shows up properly in the build summary, but libromdata
always ends up being built as a static library.
  • Loading branch information
GerbilSoft committed Sep 25, 2022
1 parent d869f38 commit 39c7743
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
rom-properties (2.0-1ppa1~xenial6) xenial; urgency=medium

* Need to set RP_LIBROMDATA_IS_DLL in the current *and* parent scope.

Otherwise, it shows up properly in the build summary, but libromdata
always ends up being built as a static library.

-- David Korth <gerbilsoft@gerbilsoft.com> Sat, 24 Sep 2022 20:02:02 -0400

rom-properties (2.0-1ppa1~xenial5) xenial; urgency=medium

* Re-add #include "dll-macros.h" to KeyStoreUI.hpp and RomFields.hpp.
Expand Down
1 change: 1 addition & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ IF(CMAKE_C_COMPILER MATCHES afl)
# afl-fuzz crashes when trying to load libromdata.so for some reason.
MESSAGE(WARNING "Disabling libromdata.so due to afl")
ELSEIF(WIN32 OR (UNIX AND NOT APPLE))
SET(RP_LIBROMDATA_IS_DLL 1)
SET(RP_LIBROMDATA_IS_DLL 1 PARENT_SCOPE)
ADD_DEFINITIONS(-DRP_LIBROMDATA_IS_DLL=1)
ELSE()
Expand Down

0 comments on commit 39c7743

Please sign in to comment.