Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask FontAwesome Icons missing in NewContentElementWizard #551

Open
nhovratov opened this issue May 19, 2023 · 15 comments
Open

Mask FontAwesome Icons missing in NewContentElementWizard #551

nhovratov opened this issue May 19, 2023 · 15 comments
Labels

Comments

@nhovratov
Copy link
Collaborator

TYPO3 v12 / Mask v8.1

mask-fa-icon

@nhovratov
Copy link
Collaborator Author

@stephangrass
Copy link

Are there any updates on this topic?

@nhovratov
Copy link
Collaborator Author

No, not really. I would recommend to use SVG icons directly.

@ursbraem
Copy link
Contributor

Does it make sense to +1 at https://forge.typo3.org/issues/100901 ?

@ursbraem
Copy link
Contributor

Also, maybe it's possible to additionally load FontAwesome directly from Mask or Sitepackage for the time being? Not?

@nhovratov
Copy link
Collaborator Author

The problem is, that the CSS is not applied anymore in the New Content Element Wizard, as it is now a Web Component. There is no workaround for Mask. I don't know if someone is willing to spend time investigating the issue in the Core.

@ursbraem
Copy link
Contributor

ursbraem commented Dec 3, 2023

About the SVG icons: they have to be wired via TS right? That's a bit tedious. Would it be future proof(er) to disable the FA selector entirely and replace it by a Field in the module?

@nhovratov
Copy link
Collaborator Author

You can put an SVG file with the Content Element name in a folder and it will be loaded automatically: https://docs.typo3.org/p/mask/mask/8.3/en-us/BackendPreview/Index.html#preview-image-for-a-content-element

@ursbraem
Copy link
Contributor

ursbraem commented Dec 4, 2023

Woot! That's great news. So I think we'll switch to that with every v12 site

@vitamys
Copy link

vitamys commented Dec 13, 2023

I added the svg icons as described (in the EXT:{your_sitepackage}/Resources/Public/Mask). However, they are still not displayed in the new content element wizard. They show up only in the page module.
image
image

@nhovratov
Copy link
Collaborator Author

@vitamys Maybe cache? Could you try to clear all browser cache + local Storage ?

@vitamys
Copy link

vitamys commented Dec 13, 2023

clearing the local Storage did the trick! Thank you!

@cyril392
Copy link

Hello,
I have the same problem (TYPO3 v12 and Mask 8.3.10). I've tried as described here and in the docs but I can't get my icon. Should we keep the fontAwesome icon definition in the mask.json? Should the files in the svg folder have specific rights? When you say the name of the content, is it the name (YouTube & Vimeo) or the key (youtube_vimeo) in your example?
I've tried clearing all my caches but nothing changes.
In my example I have the content "Accordion box" with the key "accordion_box". So what would the name of my file be?
Thanks in advance

@nhovratov
Copy link
Collaborator Author

nhovratov commented Apr 30, 2024

Should we keep the fontAwesome icon definition in the mask.json?

You can keep it, but it will do nothing. In the next Mask version, the Icon Picker will vanish completely.

Should the files in the svg folder have specific rights?

no, just the default rights for public files.

So what would the name of my file be?

It would simply be accordion_box.svg

@cyril392
Copy link

Thank you for your reply!
In the end it's the content key and in fact I was emptying the caches but not the local storage and that was the problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants