Adding info, how to run a specific version of Docker #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I've created the Gerrit change for you at https://gerrit-review.googlesource.com/c/docker-gerrit/+/271232 We will continue the review and the merge on gerrit-review.googlesource.com, hence I'll close this PR for now. |
|
Thanks @lucamilanesio I was surprised that Docker image for Gerrit uses PR but that clarifies it. |
|
@vogella could you register to gerrit-review.googlesource.com and sign the CLA? That would allow us to be able to legally merge your contribution (https://gerrit-review.googlesource.com/c/docker-gerrit/+/271232). |
|
Ping @vogella did you check if you are willing to sign the CLA for your contribution? |
|
Should be done now |
lucamilanesio
pushed a commit
that referenced
this pull request
Jun 25, 2020
GitHub-Pr: #22 Change-Id: Iab93ccec6361e55c64f87f72f33c800862e383d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Notice
Patch submission and review is done through Gerrit Code Review.
Unfortunately we cannot pull your code as a Pull Request.
NO REVIEWS OR DISCUSSIONS will happen on GitHub, all the code collaboration
will take place on Gerrit.