-
Notifications
You must be signed in to change notification settings - Fork 202
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bazel: Move java/com/google/gerrit/index:query_parser to antlr3 package
In I75d6bc4d7a antlr3 grammar sources were moved from gerrit-antlr package, but the java_library rule query_parser were missed to also be moved to antlr3 package. This is very unusual in Bazel toolchain to keep the sources in one package and build them in another. This leads to a problem: restricting package_group in java_package_configuration doesn't lead to the desired effect, as discussed in this issue: [1]. Moving the query_parser rule to the antlr3 package harmonize the location of the java_library rule to the same package where the sources are located and it also fixes the problem, that error prone warnings are not reported any more for the antlr3 grammar source in new toolchain, that doesn't list antlr3 in the package_group. ntlr3 grammar code is generated code and we would rather avoid reporting any issues in that code. [1] bazelbuild/bazel#6010 Change-Id: Iff32b6133ff7bf3f045a20fcb635d690d76e3b89
- Loading branch information
Showing
4 changed files
with
19 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters