Skip to content

Commit

Permalink
Revert ChartsOrg#4271 and disable parent scroll view on dragging
Browse files Browse the repository at this point in the history
  • Loading branch information
tsorencraig committed Jul 9, 2020
1 parent 7ac4a05 commit 22e8eca
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Source/Charts/Charts/BarLineChartViewBase.swift
Expand Up @@ -739,6 +739,10 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD
// We will only handle highlights on NSUIGestureRecognizerState.Changed

_isDragging = false

// Prevent the parent scroll view from scrolling
_outerScrollView?.nsuiIsScrollEnabled = false

}
}
else if recognizer.state == NSUIGestureRecognizerState.changed
Expand Down Expand Up @@ -790,15 +794,15 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD
}

_isDragging = false

delegate?.chartViewDidEndPanning?(self)
}

if _outerScrollView !== nil
{
_outerScrollView?.nsuiIsScrollEnabled = true
_outerScrollView = nil
}

delegate?.chartViewDidEndPanning?(self)
}
}

Expand Down

0 comments on commit 22e8eca

Please sign in to comment.