Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate app with i18next #100

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

alex-ahumada
Copy link

Please read: GetDKAN/data-catalog-components#164

Frontend translation using i18next, with browser language detection and EN/ES translations.
Added translations for page titles and FeaturedDatasets component.

@pastanislas
Copy link

Hello, is there a plan to implement this or something else that could help translating the front ? Right now, translating the search placeholder for example is challenging (as least to me ). Thank you for your work and help.

@alex-ahumada
Copy link
Author

Hi @pastanislas.

If the DKAN team wants to merge this, I can resolve the conflicts. But I'll need confirmation from their side first.
We finally forked the repo and have a live site with i18n enabled.. You can propably check the commits and make the necessary changes in your project.

@dafeder
Copy link
Member

dafeder commented May 8, 2024

Congrats on launching that site @alex-ahumada!

I know its been a while on these PRs but we do intend to get back to them soon. Not sure if you're able to update them so they merge cleanly again; I imagine your fork has diverged a bit but that would be helpful.

FYI we also have a discussion thread going on multilingual FE.

@alex-ahumada
Copy link
Author

Thanks for sharing the discussion @dafeder. I'll try to also update this PR after solving GetDKAN/data-catalog-components#164

@dafeder dafeder requested a review from brdunfield May 14, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants