Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove a harvest without deleting its datasets #3839

Closed
thierrydallacroce opened this issue Sep 22, 2022 · 2 comments
Closed

Unable to remove a harvest without deleting its datasets #3839

thierrydallacroce opened this issue Sep 22, 2022 · 2 comments

Comments

@thierrydallacroce
Copy link
Contributor

thierrydallacroce commented Sep 22, 2022

With the goal of cleaning up an old harvest from an environment where it was mistakenly added and ran, I tested both of the following approaches in a local environment:

drush dkan:harvest:deregister harvest_id 

and

drush dkan:harvest:revert harvest_id

But, both deleted the datasets.

@stefan-korn
Copy link
Contributor

@dafeder : Provided a merge request for this as discussed in #3840.

One could probably add some check if there are entities related to the harvest at all and only in that case show the warning and ask for confirmation. But maybe the warning is okay in any case?

There are also some issues with the messages from the deregister comment, which are unrelated to this. See issue #3956. #3840 and #3956 will not apply together. If either of the PRs is accepted, the other will need to be updated.

stefan-korn added a commit to stefan-korn/dkan that referenced this issue Sep 26, 2023
stefan-korn added a commit to stefan-korn/dkan that referenced this issue Oct 6, 2023
@dafeder
Copy link
Member

dafeder commented Apr 5, 2024

@stefan-korn I think we consider this resolved, feel free to re-open if you think it needs more work.

@dafeder dafeder closed this as completed Apr 5, 2024
DKAN 2 Issue Triage automation moved this from Incoming/Triage to Closed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants