Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ahoy dkan uli output #1725

Merged
6 commits merged into from
Apr 26, 2017
Merged

Fix the ahoy dkan uli output #1725

6 commits merged into from
Apr 26, 2017

Conversation

rhabbachi
Copy link
Contributor

@rhabbachi rhabbachi commented Feb 20, 2017

Issue: CIVIC-5763

Description

The previous ahoy dkan uli output is plagued with extra space that made it
difficult to strait copy and paste the command output.

This change was reviewed and introduced initially to dkan_starter
GetDKAN/dkan_starter#86

How to reproduce

  1. ahoy dkan uli should provide a login link that does not work without editing.

QA Steps

  • ahoy dkan uli is generating a working login link.

Merge process

- [ ] Note if there is a special sequence for merging (such as PRs on other repos that need to be merged first) or other abnormalities to look out for.

Reminders

- [ ] There is test for the issue.

  • CHANGELOG updated.
  • Coding standards checked.

Riadh Habbachi and others added 5 commits February 20, 2017 16:26
This change was reviewed and introduced initially to dkan_starter
GetDKAN/dkan_starter#86

The previous `ahoy dkan uli` output is plagued with extra space that made it
difficult to strait copy and paste the command output.
@janette janette added this to the 1.14 milestone Apr 25, 2017
@ghost
Copy link

ghost commented Apr 26, 2017

Tests were passing before the CHANGELOG was updated. Merging this without waiting for tests to pass again.

@ghost ghost merged commit dba664e into 7.x-1.x Apr 26, 2017
@ghost ghost deleted the dkan-uli-fix branch April 26, 2017 16:37
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Fix the `ahoy dkan uli` output

This change was reviewed and introduced initially to dkan_starter
GetDKAN/dkan_starter#86

The previous `ahoy dkan uli` output is plagued with extra space that made it
difficult to strait copy and paste the command output.

* Add CHANGELOG line

* Update CHANGELOG.txt
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Fix the `ahoy dkan uli` output

This change was reviewed and introduced initially to dkan_starter
GetDKAN/dkan_starter#86

The previous `ahoy dkan uli` output is plagued with extra space that made it
difficult to strait copy and paste the command output.

* Add CHANGELOG line

* Update CHANGELOG.txt
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants