-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ahoy dkan uli
output
#1725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was reviewed and introduced initially to dkan_starter GetDKAN/dkan_starter#86 The previous `ahoy dkan uli` output is plagued with extra space that made it difficult to strait copy and paste the command output.
Tests were passing before the CHANGELOG was updated. Merging this without waiting for tests to pass again. |
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Fix the `ahoy dkan uli` output This change was reviewed and introduced initially to dkan_starter GetDKAN/dkan_starter#86 The previous `ahoy dkan uli` output is plagued with extra space that made it difficult to strait copy and paste the command output. * Add CHANGELOG line * Update CHANGELOG.txt
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Fix the `ahoy dkan uli` output This change was reviewed and introduced initially to dkan_starter GetDKAN/dkan_starter#86 The previous `ahoy dkan uli` output is plagued with extra space that made it difficult to strait copy and paste the command output. * Add CHANGELOG line * Update CHANGELOG.txt
This was referenced Sep 15, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CIVIC-5763
Description
The previous
ahoy dkan uli
output is plagued with extra space that made itdifficult to strait copy and paste the command output.
This change was reviewed and introduced initially to dkan_starter
GetDKAN/dkan_starter#86
How to reproduce
ahoy dkan uli
should provide a login link that does not work without editing.QA Steps
Merge process
- [ ] Note if there is a special sequence for merging (such as PRs on other repos that need to be merged first) or other abnormalities to look out for.Reminders
- [ ] There is test for the issue.