Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Datasets' field on Resources form to use autocomplete #2035

Merged
merged 11 commits into from Jul 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2017

Issue: CIVIC-6574

Description

(NOTE: This PR is a redo of #1996 to include it on 1.13.6)

The dataset field on the resources form is currently listing all the available options which on sites with a big amount of datasets can be an issue. We've modified the field to use autocompletion, the same way we are doing now the dataset form to add resources.

This PR includes:

  • Changes on 'dkan_dataset.forms.inc' and 'dkan_dataset_content_types.features.field_instance.inc' to implement the fix.
  • The 'iFillInTheResourcesFieldWith' custom step was used to fill in the autocomplete 'Resources' field on the Datasets form. We needed the same kind of step in order to fill in the 'Datasets' field so the custom step was renamed to 'iFillInTheAutocompleteFieldWith' and moved out from 'DatasetContext' to 'DKANContext'.
  • Several Behat tests were fixed in order to use the new step name and/or to support the new autocomplete field.

QA Steps

  • Go to create a resource.
  • Confirm that you are able to assign it to any dataset using the autocomplete form.

Reminders

  • There is test for the issue.
  • CHANGELOG updated.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.

@dkinzer dkinzer merged commit ce7530f into 1.13.6 Jul 27, 2017
@dkinzer
Copy link

dkinzer commented Jul 27, 2017

I reviewed the dataset components docs and I don't think we need to make changes based on this PR. QA steps are met ad tests are passing so I'm merging.

@dkinzer dkinzer deleted the 6564_autocomplete_dataset_field_1_13_6 branch July 27, 2017 19:31
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Changed dataset field on resource form to be autocomplete

* Fixed code style errors

* Fixed automatic reference to datasets

* Update CHANGELOG.txt

* Update dkan_dataset.forms.inc

* Refactored step used to fill in autocomplete fields

* Fixed tests

* Removed unused step

* Added javascript tagas

* Fixed tests
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Changed dataset field on resource form to be autocomplete

* Fixed code style errors

* Fixed automatic reference to datasets

* Update CHANGELOG.txt

* Update dkan_dataset.forms.inc

* Refactored step used to fill in autocomplete fields

* Fixed tests

* Removed unused step

* Added javascript tagas

* Fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants