Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for partial date elements when validating #2778

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Add check for partial date elements when validating #2778

merged 1 commit into from
Jan 7, 2019

Conversation

janette
Copy link
Member

@janette janette commented Dec 18, 2018 •
edited by dharizza

connects #2688

How to reproduce

  1. Create a harvest source from https://api.myjson.com/bins/v2248
  2. Confirm you get errors
    modified

QA Steps

Reminders

  • There is test for the issue.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.

@dharizza dharizza merged commit 0e10005 into 7.x-1.x Jan 7, 2019
@dharizza dharizza deleted the 2688-validate-date branch January 7, 2019 22:46
dafeder pushed a commit that referenced this pull request Apr 24, 2020
@dharizza
Merge pull request #2778 from GetDKAN/2688-validate-date
aa075c7 
Add check for partial date elements when validating
dafeder pushed a commit that referenced this pull request Apr 24, 2020
@dharizza
Merge pull request #2778 from GetDKAN/2688-validate-date
6e4da4f 
Add check for partial date elements when validating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharizza dharizza dharizza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janette @dharizza