Use dkan_allowed_extensions() during harvest #2781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #2577
Description.
The
dkan_allowed_extensions()
function (added in #2664 is the way to go when overriding resources allowed extensions. During a harvest a check on the allowed extensions is done to honor the user setting. This PR will update this check (done in HarvestMigration::prepareResourceHelper) to usedkan_allowed_extensions()
instead of querying the field settings.How to reproduce
Step-by-step instructions for reproducing the bug:
dkan_allowed_extensions()
.Expected:
All the resources are harvested and imported correctly.
Currently:
Resources with non default extensions introduced via
dkan_allowed_extensions()
fail to be harvested.QA Steps
dkan_allowed_extensions()
mechanism.The Harvest should proceed without issues.
Merge process
Reminders