Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dataset and Resource(s) Orphan Field Update Harvest Post Import Operations #2782

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

rhabbachi
Copy link
Contributor

@rhabbachi rhabbachi commented Dec 26, 2018

Description

During post import operations, Harvest will check if the dataset is still provided by the source or not, and will update the publishing status and field_orphan property/field to reflect the dataset situation. Currently the logic will update the publish status of the dataset/resource(s) correctly but will miss the field_orphan field update. This will lead to conflicting results on the "Manage Datasets" tab.

How to reproduce

  1. Create a Harvest Source with a source that can be altered later.
  2. Harvest the Source, this should result in all the datatsets and associated resources published status set to TRUE and the field_orphan status set to FALSE.
  3. Alter the Source to delete a single test dataset.
  4. Harvest the Source, this should result in the test datatset and associated resource(s) published status set to FALSE and the field_orphan status set to TRUE.
  5. Alter the Source to restore the test dataset.
  6. Harvest the Source.

Expected:
The final action should result in the test datatset and associated resource(s) published status set to TRUE and the field_orphan status set to FALSE

Current:
The final action results in the test datatset and associated resource(s) published status set to TRUE but the field_orphan status set to TRUE

Reminders

  • There is test for the issue.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.

Connects #2085

@dafeder dafeder self-assigned this Dec 26, 2018
@dafeder dafeder removed their assignment Dec 28, 2018
@janette janette merged commit 44efa5f into GetDKAN:7.x-1.x Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants