Fix Dataset and Resource(s) Orphan Field Update Harvest Post Import Operations #2782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During post import operations, Harvest will check if the dataset is still provided by the source or not, and will update the publishing status and field_orphan property/field to reflect the dataset situation. Currently the logic will update the publish status of the dataset/resource(s) correctly but will miss the field_orphan field update. This will lead to conflicting results on the "Manage Datasets" tab.
How to reproduce
Expected:
The final action should result in the test datatset and associated resource(s) published status set to TRUE and the field_orphan status set to FALSE
Current:
The final action results in the test datatset and associated resource(s) published status set to TRUE but the field_orphan status set to TRUE
Reminders
Connects #2085