Update Harvest node machine name field settings to limit length and replace single hypen #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great @rhabbachi can you also update the help text to include the character limit in case the user is adding similar long source names
|
|
@janette Done! |
|
Fabulous! Thank you @rhabbachi |
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
…eplace single hypen (#2784) * Update Harvest node machine name field setting to limit length and hyphen * Update the help text to include the character limit
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
…eplace single hypen (#2784) * Update Harvest node machine name field setting to limit length and hyphen * Update the help text to include the character limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #2635
We ran into similar issues as stated in #2635, when a site admin tries to be too explicit with the Harvest Source name and hits database field limitations in terms of length and allowed characters.
How to reproduce
See #2635
QA Steps
Titlefield.Result: the machine name should show "harvest_machine_name_that_is_to"
Merge process
Reminders