Support harvest dataset source identifiers that ends with a '/' #2785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harvest sources with datasets
identifier
fields that ends with "/" (for examplehttp://dx.doi.org/10.7927/H4PZ56R2/
) will result in an empty generated identifier during the Harvest.This PR tweaks the
dkan_harvest_datajson_prepare_item_id
function to account for this case and return the last non empty segment of theidentifier
.How to reproduce
identifier
that is a URL that ends with a "/" (in the following example theidentifier
is "http://demo.getdkan.com/90a2b708-7fea-4b92-8aee-43c4cfdd5f48/").Expected Behavior:
Harvest works.
Current Behavior:
Harvest fail and identifier recorded is empty.
QA Steps
Merge process
Reminders