Drush command for deleting orphaned legacy datastore tables #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
requested changes
Mar 7, 2019
| // Delete ghost datastore tables. | ||
| $items['dkan-datastore-delete-ghost-tables'] = array( | ||
| 'aliases' => array('dkan-datastore-dgt'), | ||
| 'description' => 'Delete ghost datastore tables if they exist.', |
There was a problem hiding this comment.
We've been using the term "ghost" casually for this but I don't think it's very clear to others. Let's switch "ghost" for "orphan," and "deleted" for "dropped" while we're at it. So let's call it dkan-datastore-drop-orphan-tables) And while we're at it let's make that alias a little shorter and consistent with our conventions: dkan-dot.
| } | ||
| } | ||
| if (!empty($nids)) { | ||
| drush_print("Looking through " . implode(', ', $nids)); |
There was a problem hiding this comment.
Let's say for this "Checking for the following nodes: "
| drush_print("Deleted ghost table $table"); | ||
| } | ||
| } else { | ||
| drush_print("There is currently no datastore tables."); |
There was a problem hiding this comment.
"There are currently no datastore tables on this site."
| drush_print("Ghost tables found: $ghosts"); | ||
| foreach ($to_truncate as $table) { | ||
| $query = db_drop_table($table); | ||
| drush_print("Deleted ghost table $table"); |
|
@dafeder fixed. |
dafeder
approved these changes
Mar 7, 2019
dafeder
changed the title
3 tasks
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
Drush command for deleting orphaned legacy datastore tables
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
Drush command for deleting orphaned legacy datastore tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User story
The ghost datastore tables are those for which there doesn't exist a related node, for example there exist a table
feeds_datastore_dkan_file_10000but there isn't a node with id10000. Here we're adding a new drush commanddrush dkan-datastore-delete-ghost-tableswith aliasdrush dkan-datastore-dgtto find ghost datastore tables and delete them.QA Steps
drush dkan-datastore-drop-orphan-tablesordrush dkan-datastore-dotyou'll get the following behaviour:Connects NuCivic/dkan_management#171