Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the datastore lock code #2876

Merged
merged 1 commit into from
May 22, 2019
Merged

Update the datastore lock code #2876

merged 1 commit into from
May 22, 2019

Conversation

janette
Copy link
Member

@janette janette commented May 13, 2019

Reminders

  • There is test for the issue.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.

@janette
Copy link
Member Author

janette commented May 21, 2019

lock is stored in a global lock variable, requesting a new lock will extend the expiration of the lock and return true. So to test a failed lock we need it to be called from a separate process.

to test we need a server to request a url
https://api.drupal.org/api/drupal/modules%21simpletest%21tests%21lock.test/function/LockFunctionalTest%3A%3AtestLockAcquire/7.x

hypothesis: use a drush command to acquire a lock, run a second drush command to also acquire the lock

Create a new ticket.

@dharizza dharizza merged commit 35fc360 into 7.x-1.x May 22, 2019
@dharizza dharizza deleted the datastore-lock branch May 22, 2019 17:55
dafeder pushed a commit that referenced this pull request Apr 24, 2020
dafeder pushed a commit that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants