Separate harvest classes into separate files and do some light cleanup #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now includes commits from #2978 |
dafeder
added a commit
that referenced
this pull request
Jan 22, 2020
#2983) * No revision on og group sync changes * Eliminate extra revisioning in harvest * Separate harvest classes into separate files and do some light cleanup * Restore getIdList() command to HarvestMigration * Extend stringIfExists to all multiple elements.
dafeder
added a commit
that referenced
this pull request
Mar 31, 2020
#2983) * No revision on og group sync changes * Eliminate extra revisioning in harvest * Separate harvest classes into separate files and do some light cleanup * Restore getIdList() command to HarvestMigration * Extend stringIfExists to all multiple elements.
dafeder
added a commit
that referenced
this pull request
Apr 24, 2020
#2983) * No revision on og group sync changes * Eliminate extra revisioning in harvest * Separate harvest classes into separate files and do some light cleanup * Restore getIdList() command to HarvestMigration * Extend stringIfExists to all multiple elements.
dafeder
added a commit
that referenced
this pull request
Apr 24, 2020
#2983) * No revision on og group sync changes * Eliminate extra revisioning in harvest * Separate harvest classes into separate files and do some light cleanup * Restore getIdList() command to HarvestMigration * Extend stringIfExists to all multiple elements.
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop creating new revisions throughout the dataset creation process in Harvest, so that we have a cleaner history revision history on newly harvested datasets.
Also, refactoring to make code easier to work with.
Note: The cache dir logic now goes in HarvestMigration by default, and does not need to be added in additional migration classes. See https://github.com/GetDKAN/dkan/pull/2983/files#diff-4e04b5611bd1607adc9902f7c27dbbbcL20-L21
QA Steps
If tests pass, try running an HHS or LKY harvest using this branch to make sure no ill-effects. You should see a reduced number of revisions (actually, just one revision) on new datasets.
Everything should work the same.