Check accrualPeriodicity against list of valid frequency values. #3021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the validity of the accrualPeriodicity field in
prepareRow()
.User story
If a json harvest has an
accrualPeriodicity
value, that value gets saved to thefrequency
field, even if the value isn't valid for the field.The pr adds a check to prepare row. If the value is a valid key value for field_frequency, there is no change. If it is a valid display value, it is set to the key value. If it is neither, it is set to null.
How to reproduce
accrualPeriodicity
.QA Steps
accrualPeriodicity
fields.a. Give one a valid Frequency key (e.g.
R/P1D
).b. Give another a valid Frequency value (e.g.
Daily
).c. Give the third an invalid value