Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore char encoding #3025

Merged
merged 6 commits into from
Feb 20, 2020
Merged

Datastore char encoding #3025

merged 6 commits into from
Feb 20, 2020

Conversation

beeyayjay
Copy link

@beeyayjay beeyayjay commented Feb 18, 2020

fixes #2901

Description. Adds ability to add non UTF-8 files to datastore.

User story

Currently datastore breaks if the file isn't in UTF-8 .
This adds a select list of allowed PHP encodings to the datastore form. A user can choose the appropriate encoding for the file.

QA Steps

  1. Create a new resource, uploading /dkan/test/phpunit/dkan_datastore/data/win1252_encoding.csv.
  2. Note that the data preview displays bad characters in the 'title' field
  3. Go to 'Manage Datastore' and select 'Windows-1252' as the Character encoding.
  4. Click 'Import'.
  5. Confirm that the file imports successfully and the special characters now display properly in data preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-UTF-8 option to datastore import
2 participants