Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for WCAG2AA compliance #3095

Merged
merged 2 commits into from
May 13, 2020
Merged

Updates for WCAG2AA compliance #3095

merged 2 commits into from
May 13, 2020

Conversation

janette
Copy link
Member

@janette janette commented May 13, 2020

fixes #3079

  • Update data-format colors for contrast
  • Add scope attribute to Additional Info table on dataset page

QA steps

contrast

  • Add dummy resources to a dataset (title and format only) for
    • html
    • geojson
    • xml
    • text
    • xls
    • data
  • view the dataset with the search page search/type/dataset
  • run WCAG2AA test (drag bookmarklet to bookmarks bar https://squizlabs.github.io/HTML_CodeSniffer/)
  • confirm you get 0 errors

table cells

  • go to a dataset and run the WCAG2AA test
  • confirm you do not get errors on the Additional Info table

@dafeder
Copy link
Member

dafeder commented May 13, 2020

Got an error on the search form at the top of /search
image

@dafeder
Copy link
Member

dafeder commented May 13, 2020

Errors seem to be particular to Firefox on Linux, or maybe specifically my Firefox (don't appear for me in Chrome, don't appear in Firefox for mac)

@dafeder dafeder merged commit f3bc884 into 7.x-1.x May 13, 2020
@dafeder dafeder deleted the 3079-wcag branch May 13, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants