Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove idenitfier/data wrapper, take 2 #3504

Draft
wants to merge 34 commits into
base: 2.x
Choose a base branch
from
Draft

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Jun 3, 2021

fixes [/issues/3450]

  • All tests pass
  • JSON metadata stored in the database is not wrapped with with [{"data":{},"identifier":""}]
  • API GET requests return the same JSON format as before (the data is wrapped with [{"data":{},"identifier":""}])

QA Steps

  • Post a dataset with referenced entities (distributions, publisher, keyword, etc)
  • Make sure that JSON metadata stored in the database is not wrapped with [{"data":{},"identifier":""}]
  • Run GET requests to get entities of various schemas. Make sure that JSON output has not changed compared to 2.x.

nvolodin and others added 30 commits May 27, 2021 11:16
Turned the associative datasets array into an indexed array.
@dafeder dafeder added this to In progress in DKAN 2 Development via automation Jun 3, 2021
@dafeder dafeder moved this from In progress to To do in DKAN 2 Development Jun 4, 2021
@dafeder dafeder marked this pull request as draft May 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant