Update to PHP_CodeSniffer version 3.6 via CC beta channel #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clayliddell I'm into it, let's keep this open. Can you try running phpcbf and seeing how much of this can be fixed automatically? |
dafeder
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR because CodeClimate's stable channel is still using PHP_CodeSniffer version 2, which doesn't have support for many features added in PHP 7+ (which is why we've been seeing quite a few false positives for non-issues surrounding these new features). If we decide to merge this PR, we'll need to do some clean up around the code base to take care of the list of new issues CodeClimate has detected.