Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sitemap for DKAN URLs #3722

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Generate sitemap for DKAN URLs #3722

merged 4 commits into from
Dec 15, 2021

Conversation

clayliddell
Copy link
Contributor

@clayliddell clayliddell commented Dec 6, 2021

fixes WCMS-7259

  • Test coverage exists
  • Documentation exists

QA Steps

  • Install simple_sitemap module.
  • Run cron to allow sitemap to be generated.
  • Navigate to /sitemap.xml and ensure a valid sitemap has been created with static links and dataset links.

Clayton Liddell added 2 commits December 6, 2021 13:07
@clayliddell clayliddell changed the title Geneate sitemap for DKAN urls Generate sitemap for DKAN URLs Dec 7, 2021
@clayliddell
Copy link
Contributor Author

clayliddell commented Dec 10, 2021

I think we should just ignore the lastmod tag for now. A Google Employee on StackOverflow says it's usually ignored and according to the Sitemap protocol documentation, it's an optional tag.

@dafeder
Copy link
Member

dafeder commented Dec 10, 2021

Thanks for looking into this @clayliddell, I'll defer to you opinion based on your research.

@dafeder dafeder merged commit 113b1e3 into 2.x Dec 15, 2021
@dafeder dafeder deleted the 7259-sitemap branch December 15, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants