Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bulk moderation modals in Cypress tests #3769

Merged
merged 2 commits into from Mar 21, 2022
Merged

Remove bulk moderation modals in Cypress tests #3769

merged 2 commits into from Mar 21, 2022

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Mar 21, 2022

The moderated_content_bulk_publish module has helped with the functionality around moderation states, but it also has introduced a lot of confirmation dialogs that are breaking our tests. Hopefully these modals will be optional soon - see https://www.drupal.org/project/moderated_content_bulk_publish/issues/3185848

In the meantime, this PR adds the extra click needed to our cypress tests.

QA Steps

  • Tests should not fail on form submit

@dafeder dafeder marked this pull request as draft March 21, 2022 15:49
@dafeder dafeder changed the title Remove bulk moderation modals Remove bulk moderation modals in Cypress tests Mar 21, 2022
@dafeder dafeder marked this pull request as ready for review March 21, 2022 21:10
Copy link
Member

@dgading dgading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress tests look good.

@dgading dgading merged commit 9c88a5c into 2.x Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants