Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test users #3779

Merged
merged 17 commits into from May 10, 2022
Merged

Update test users #3779

merged 17 commits into from May 10, 2022

Conversation

janette
Copy link
Member

@janette janette commented Apr 28, 2022

REF: WCMS-6450
Companion PR to: GetDKAN/dkan-tools#328

  • Test coverage exists
  • Documentation exists

@janette janette changed the title Wcms 6450 Update test users Apr 29, 2022
Copy link
Contributor

@clayliddell clayliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. I left a bit of feedback, some questions, and some comments.

.circleci/config.yml Show resolved Hide resolved
.codeclimate.yml Outdated Show resolved Hide resolved
cypress/integration/09_admin_links.spec.js Show resolved Hide resolved
@clayliddell
Copy link
Contributor

Since only 1 line of PHP was modified in this PR, I'm not to worried about PHP CS on this 😃

@clayliddell clayliddell self-requested a review May 10, 2022 14:48
@clayliddell clayliddell merged commit 7168e58 into 2.x May 10, 2022
@clayliddell clayliddell deleted the WCMS-6450 branch May 10, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants