Turn off strict mode on import #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayliddell
suggested changes
May 16, 2022
Co-authored-by: Clayton Liddell <clayton.liddell@civicactions.com>
|
Hmm committed your suggestions @clayliddell but seeing it's failing one of the PHPunit runs, but not the other. Weird, will take another look. |
…nodb-create-table
This reverts commit 8750aa8.
dafeder
force-pushed
the
innodb-create-table
branch
from
a8fdffb
to
005801e
Compare
|
Moved this into the datastore's DatabaseTable class, after realizing that's where the table creation is actually happening. |
1 similar comment
|
Moved this into the datastore's DatabaseTable class, after realizing that's where the table creation is actually happening. |
clayliddell
suggested changes
May 23, 2022
clayliddell
approved these changes
May 24, 2022
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict mode on innodb makes it hard to create tables over 200 columns, which has come up in real world use. This sets strict mode off simply at the session level for the datastore, and keeps it on for the rest of Drupal's operation.
This has been tested locally and successfully created a 252 column table in the same environment where it had previously failed.