Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Data: Create new content" permission for data-dictionary menu access #3817

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

clayliddell
Copy link
Contributor

@clayliddell clayliddell commented Aug 18, 2022

Currently only administrators have access to the DKAN > Data-Dictionary menu. This changes that so that data-publishers and anyone with permission to create data content also have access.

  • Test coverage exists
  • Documentation exists

QA Steps

  • Ensure that as a user with the "Data: Create new content" permission you have access to the DKAN > Data-Dictionary menu.

@clayliddell clayliddell changed the title Use "Create Data Content" permission for data-dictionary menu access Use "Data: Create new content" permission for data-dictionary menu access Aug 18, 2022
Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayliddell You want data publishers to have access to the settings as well correct?

My test role required the following permissions:

  • create data content
  • access admin theme
  • Access the Content overview page
  • View the administration theme
  • DKAN publishing workflow: Use Publish transition.
  • View published content
    THEN I can create a data-dictionary

BUT I still do not have access to the Data-Dictionary Settings screen because of
https://github.com/GetDKAN/dkan/blob/2.x/modules/metastore/metastore.routing.yml#L176

@janette janette merged commit 7220072 into 2.x Aug 19, 2022
@clayliddell clayliddell deleted the fix-dd-permission branch August 19, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants