Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codeclimate reporter #3845

Merged
merged 31 commits into from
Oct 28, 2022
Merged

add codeclimate reporter #3845

merged 31 commits into from
Oct 28, 2022

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Oct 7, 2022

fixes [WCMS-10643]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

dafeder
dafeder approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Psyched to see this working again.

@dafeder dafeder merged commit b15144f into 2.x Oct 28, 2022
@dafeder dafeder deleted the WCMS-10643-codeclimate branch October 28, 2022 13:17
@dafeder
Copy link
Member

dafeder commented Oct 28, 2022

BTW it looks like overall coverage has dropped to 94%, would like to see that come back above 95.

@paul-m paul-m mentioned this pull request Oct 28, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paul-m @dafeder