Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tsv support to datstore_mysql_import #3880

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Add tsv support to datstore_mysql_import #3880

merged 4 commits into from
Nov 23, 2022

Conversation

janette
Copy link
Member

@janette janette commented Nov 21, 2022

First draft, ideally we want to allow user to define parser config: delimiter, eol, escape, enclosed.

@janette janette force-pushed the WCMS-12280 branch 2 times, most recently from c276b18 to 1060626 Compare November 22, 2022 02:11
tiffneybare
tiffneybare approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@tiffneybare tiffneybare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good locally

@tiffneybare tiffneybare merged commit ee439c6 into 2.x Nov 23, 2022
@tiffneybare tiffneybare deleted the WCMS-12280 branch November 23, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffneybare tiffneybare tiffneybare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janette @tiffneybare