Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of deprecated themes in the frontend module #3933

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Remove mention of deprecated themes in the frontend module #3933

merged 4 commits into from
Apr 14, 2023

Conversation

janette
Copy link
Member

@janette janette commented Apr 3, 2023 •
edited
Loading

combine with GetDKAN/ddev-dkan#30

QA:

  1. checkout this branch
  2. ddev get https://github.com/GetDKAN/dkan-ddev-addon/archive/refs/heads/frontend-command-refresh.tar.gz
  3. ddev dkan-frontend-install
  4. ddev dkan-frontend-build
  5. ddev launch

AC:

  • Frontend app builds from the 1.3.0 tag
  • Header and footer are blue (looks similar to the current demo site)
  • No drupal drop background image.

@janette janette changed the base branch from 2.x to d10-deprecations April 4, 2023 15:44
@janette janette marked this pull request as ready for review April 4, 2023 15:44
@jastraat jastraat force-pushed the d10-deprecations branch 2 times, most recently from 6e2aec0 to daa9f8b Compare April 10, 2023 19:47
@janette janette changed the base branch from d10-deprecations to 2.x April 10, 2023 21:48
@janette janette changed the title Remove Bartik dependence Remove mention of deprecated themes in the frontend module Apr 10, 2023
jastraat
jastraat approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed a fresh demo site using this branch + the version of the ddev referenced. Blue header is present with no background image.

@jastraat jastraat merged commit 0aadbd0 into 2.x Apr 14, 2023
@jastraat jastraat deleted the remove-bartik branch April 14, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janette @jastraat