Move config_update dependency to recommended project #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jastraat
changed the title
jastraat
changed the title
paul-m
approved these changes
Apr 6, 2023
|
We have a bit of a logjam, having specified the constraints incorrectly in dkan core. Removing the dependency solves that. |
jastraat
force-pushed
the
remove_config_update
branch
from
9452b66
to
eb8de0d
Compare
jastraat
changed the title
jastraat
force-pushed
the
remove_config_update
branch
from
eb8de0d
to
0c05b13
Compare
jastraat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move config_update module dependency out of DKAN's composer and into project/recommended-project composer files.
The config_update removal is required in order to allow D10 tests to run successfully, so until this is merged, GetDKAN/recommended-project#28 will fail and we cannot subsequently run D10 tests for #3931
This is quite a blocker.
WCMS-14268 needs to be completed before open data sites can take advantage of the release containing this change.