Run some functional tests in separate processes #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
changed the title
dafeder
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky test failures in
DatasetTest.It turns out the culprit is the fact that DKAN uses
drupal_static()for some state info.Since all the tests run in the same process, the
metastore_resource_mapper_displayandmetastore_resource_mapper_new_revisiondrupal_static()variables retain their state across tests.The solution is to annotate the tests which might use these variables so that they run in separate processes, which keeps the static values isolated.
This PR also adds 5 extra test runs per environment. Initially I set it to 10, but that caused a failure in the environment where we enabled XDebug for code coverage reports. At either 5 or 10, this demonstrates that the tests stops being flaky.
This PR also marks
ImportJobTest::testMultiplePasses()as incomplete, since it is also flaky. We'll file a follow-up to fix it.Before merging, the PR will need to be modified to remove the extra test runs.