Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3959: dkan:harvest:status - undefined array key #3960

Merged
merged 2 commits into from May 17, 2023
Merged

Issue #3959: dkan:harvest:status - undefined array key #3960

merged 2 commits into from May 17, 2023

Conversation

stefan-korn
Copy link
Contributor

@stefan-korn stefan-korn commented May 8, 2023 •
edited by jastraat

fixes [GetDKAN/dkan/#3959]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Register a harvest using a local json file: ddev drush dkan:harvest:register --identifier=h1 --extract-uri=https://mylocal.ddev.site/sites/default/files/h1.json
  • Run the harvest: ddev drush dkan:harvest:run h1
  • -- Returns output showing it processed successfully
  • Get the status with drush: ddev drush dkan:harvest:status h1
  • -- Returns status without "Undefined array key" error

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jastraat
Copy link
Contributor

@stefan-korn you may want to rebase on 2.x to pull in the latest changes to Cypress tests.

jastraat
jastraat approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the QA steps as outlined before applying this fix: saw the described error. And then ran through with the fix: no error.

@jastraat jastraat merged commit 3dca64c into GetDKAN:2.x May 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefan-korn @jastraat