Factor out drupal_static for resource display #3965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal has had a meta issue to remove all drupal_static calls in core and deprecate the functionality. With that in mind, we're working to move the configuration of the resource download url in the metadata to configuration (that can be edited through the UI) instead of using drupal_static.
This change will need to be reflected in the release notes so that sites who are currently calling &drupal_static('metastore_resource_mapper_display')
know that they will need to update their code.
Included changes:
metastore_resource_mapper_display static variable fully removed
new configuration setting in metastore.settings called 'resource_perspective_display' with two options: source (default) and local_url
retrieveDownloadUrlFromResourceMapper() uses the new config setting to determine how to display the download url
The new config setting can be modified on the Resources form.
Test coverage exists
Documentation exists
QA Steps