Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3512: Create special form widget for vCard email field #3966

Merged
merged 1 commit into from May 17, 2023

Conversation

stefan-korn
Copy link
Contributor

@stefan-korn stefan-korn commented May 12, 2023

possible fix to #3512

This only addresses the issue with editing the email field through the UI for a vCard with the hasEmail property that was imported via the API.

Steps to Recreate

  • Create a dataset through the API / via a harvest that has a contactPoint with the hasEmail property

"contactPoint": { "@type": "vcard:Contact", "fn": "First Name", "hasEmail": "mailto:email@example.com" },

  • Attempt to edit the dataset through the UI. The validation of the email field fails.

QA Steps

  • Create a dataset through the API / via a harvest that has a contactPoint with the hasEmail property
  • Only the email appears in the email form field (no mailto:)
  • Edit and save the dataset through the UI without an error.
  • When visiting the API path for the metastore ( /api/1/metastore/schemas/dataset/items/{identifier} ) the hasEmail still shows the mailto: prefix.

Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the QA steps as outlined, and this allowed editing a previously created via the API dataset with an email containing a hasEmail property through the UI and saving successfully.

@jastraat jastraat merged commit bb8fadb into GetDKAN:2.x May 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants