Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace call to core search index function with rendering all nodes. #3975

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

jastraat
Copy link
Contributor

@jastraat jastraat commented May 30, 2023

Currently we are using the standard installation profile for Drupal when running DKAN tests. This is due to a strange dependency in the functional tests on the core search module (which is not installed or used on most DKAN sites.)

This PR replaces that dependency with simply rendering the nodes from the node table.

Arguably, this test does not make sense since it's unclear what it proves.

Committing this PR should unblock #3922

  • Test coverage exists
  • Documentation exists

@jastraat jastraat requested a review from janette May 30, 2023 21:56
@janette janette merged commit 90fe1ca into 2.x Jun 5, 2023
@janette janette deleted the remove_search_dependency branch June 5, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants