-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11948 Use pre-existing local file for import #3996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work here @paul-m. Take a look at a few suggestions and questions I had.
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
dafeder
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, looks like we need to re-run a cypress test though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataResource
now hasgetUniqueIdentifierNoPerspective()
, to go along with its existinggetUniqueIdentifier()
, and updating places where the no perspective id was being created on the fly.always_use_existing_local_perspective
. It’s a bool, and makes your DKAN override the file fetcher to use an existing file rather than copy one from the source.always_use_existing_local_perspective
enabled.\Drupal\common\FileFetcher\Factory
is now\Drupal\common\FileFetcher\FileFetcherFactory
. This name change comes along with the ability to check thealways_use_existing_local_perspective
configuration and use our new file-fetcher remote processor depending on what it says.\Drupal\common\FileFetcher\FileFetcherRemoteUseExisting
, which is a file fetcher processor to replaceRemote
if we want to use the existing file.There's no integrity check performed on the file, other than whether it exists in the file system... For instance the file could exist but be zero bytes long. We'll follow up with issues about this process.